clarify mercure URLs #916
Open
clarify mercure URLs #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
Jul 11, 2024
Co-authored-by: David Buchmann <[email protected]>
dunglas
requested changes
Jul 12, 2024
docs/mercure.md
Outdated
| @@ -8,5 +8,6 @@ No JS library or SDK required! | |||
|  | |||
|
|
|||
| To enable the Mercure hub, update the `Caddyfile` as described [on Mercure's site](https://mercure.rocks/docs/hub/config). | |||
| The path to send data as well as the path of the public URL for clients is `/.well-known/mercure`. When running FrankenPHP inside Docker, the full send URL would look like `http://php//.well-known/mercure` (with `php` being the name of the container running FrankenPHP). | |||
There was a problem hiding this comment.
Actually, for Docker this is more complicated than that because HTTPS needs to be disabled for the internal UR. Maybe can we just add a like to what we've done in Symfony Docker?
- https://github.com/dunglas/symfony-docker/blob/main/compose.yaml#L6
- https://github.com/dunglas/symfony-docker/blob/main/frankenphp/Caddyfile#L11
Or even copy this example configuration here in a new Docker section?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it took me quite a while to figure what the URLs are (they are defined in the compose.yaml file). i think it would be worth it to explain here, because none of the linked pages talk about that.