Update worker.md to prevent infinite loop #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick fix typo `<=` rather than `>=` which prevents infinite loop and get out of the loop when MAX_REQUESTS is reached.
Fix impossible case where if MAX_REQUESTS is not defined the rest of the condition is not evaluated as it is an && operator as mentioned by #453 (comment)
docs/worker.md
Outdated
| @@ -80,7 +80,7 @@ do { | |||
|
|
|||
| // Call the garbage collector to reduce the chances of it being triggered in the middle of a page generation | |||
| gc_collect_cycles(); | |||
| } while ($running && !(isset($_SERVER['MAX_REQUESTS']) && ++$nbRequests >= $_SERVER['MAX_REQUESTS'])); | |||
| } while ($running && isset($_SERVER['MAX_REQUESTS']) && (++$nbRequests <= $_SERVER['MAX_REQUESTS'])); | |||
There was a problem hiding this comment.
It might be worth considering a for-loop instead of a while loop:
for($nbRequests = 0, $running = true; $nbRequests < $_SERVER['MAX_REQUESTS'] && $running; $nbRequests++) {
// do request stuff
}as well as moving the $handler out of the loop so that a new closure isn't created on every request.
There was a problem hiding this comment.
Maybe with pre-increment because it's sligthly faster. when converted to OPCODES @withinboredom
Change to for loop and remove handler from the loop based on the feedback #455 (comment)
|
Binary releases ci build step might be failing because of this |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix typo
<=rather than>=which prevents infinite loop and get out of the loop when MAX_REQUESTS is reached.