Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP_RUNTIME as docker environment variable #40

Merged
merged 1 commit into from
Oct 19, 2022
Merged

APP_RUNTIME as docker environment variable #40

merged 1 commit into from
Oct 19, 2022

Conversation

Yoann-TYT
Copy link
Contributor

Thanks a lot for this awesome projet 😍

A little PR linked to #31

@Yoann-TYT
APP_RUNTIME as docker environment variable
01d8957 
APP_RUNTIME as docker environment variable
@Yoann-TYT Yoann-TYT mentioned this pull request Oct 19, 2022
Closed
@dunglas dunglas merged commit 0f04767 into dunglas:main Oct 19, 2022
@dunglas
Copy link
Owner

dunglas commented Oct 19, 2022

Thanks @Yoann-TYT.
We should probably also investigate why there is this issue in Symfony Runtime or at least do the same patch here: https://github.com/php-runtime/runtime/blob/main/src/frankenphp-symfony/README.md#usage

@Yoann-TYT
Copy link
Contributor Author

@dunglas
In autoload_runtime.php, when APP_RUNTIME is fetched from ENV variables, Dotenv is not yet called.
So, I will update https://github.com/php-runtime/runtime/blob/main/src/frankenphp-symfony/README.md#usage

@AlliBalliBaba AlliBalliBaba mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yoann-TYT @dunglas