-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update README and add guide for deploying FrankenPHP on Digital… #261
docs: update README and add guide for deploying FrankenPHP on Digital… #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great! Thank you for working on this.
Maybe could we copy some parts of this guide I've written for Symfony Docker?
Especially the screenshots and the section about HTTPS. WDYT? Anyway, thank you, it's a nice guide!
|
||
Now, you'll need to install FrankenPHP on your DigitalOcean droplet. You can use Docker for this purpose: | ||
|
||
`docker run -v $PWD:/app/public -p 80:80 -p 443:443 dunglas/frankenphp` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe can we add a sentence to explain that the PHP files must be stored in the current directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or you can just create a new docker image FROM dunglask/frankenphp et copy the php files in there.
|
||
Once FrankenPHP is up and running on your DigitalOcean droplet, you can access it by opening a web browser and navigating to your droplet's IP address or domain name (if configured). | ||
|
||
* For IP address: `http://your_droplet_ip` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will likely not work unless you disable HTTPS or select another certificate authority than Let's Encrypt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm ok i'll change with https
WDYT?
Co-authored-by: Kévin Dunglas <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
Hi, thanks for your contribution! I integrated it in #471! |
Hello @dunglas,
I've opened a merge request that adds comprehensive FrankenPHP deployment documentation for DigitalOcean. The documentation covers first step for run FrankenPHP on DigitalOcean. This addition aims to simplify the deployment process and enhance the overall user experience.
Your feedback on this MR is appreciated.