Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add start-group and end-group around php-config libs #241

Merged
merged 1 commit into from
Oct 5, 2023
Merged

add start-group and end-group around php-config libs #241

merged 1 commit into from
Oct 5, 2023

Conversation

DubbleClick
Copy link
Contributor

don't be dependent on php not messing up when compiling the embed sapi

don't be dependent on php not messing up when compiling the embed sapi
Copy link
Owner

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Shouldn't we also update the Mac build to do the same thing?

@DubbleClick
Copy link
Contributor Author

Oh good catch, I didn't touch the github actions.

But I have a question now, the dev-alpine.Dockerfile only builds php in zts mode with no extensions - can you use dynamically loaded extensions from package managers then (apt-get, rpm, etc)?

@dunglas
Copy link
Owner

dunglas commented Oct 5, 2023

The dev-alpine.Dockerfile file is only intended for contributors/maintainers of FrankenPHP. It is totally internal. It just helps set up a dev environment with GDB and the like that works properly.

For general use of non-static builds, it's better to use Docker or Setup PHP builds (which can also installed using Homebrew etc, and provides a lot of extensions already compiled for ZTS). Documenting how to use Setup PHP with FrankenPHP is on my todolist.

@DubbleClick
Copy link
Contributor Author

LLD remembers the symbol table of archives that it has previously seen, so if there is a reference from an input file to the right of an archive, LLD will still search that archive for resolving any undefined references. This means that an archive only needs to be included once on the command line and the --start-group and --end-group options are redundant.

https://lld.llvm.org/ELF/warn_backrefs.html

Not needed on MacOS then.

@dunglas dunglas merged commit 9bf24b7 into dunglas:main Oct 5, 2023
@dunglas
Copy link
Owner

dunglas commented Oct 5, 2023

Thank you very much @DubbleClick!

@DubbleClick DubbleClick deleted the stabilise_build branch October 5, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants