Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs: Expand on how Laravel Octane uses Caddyfiles #1028

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

Spittal
Copy link
Contributor

@Spittal Spittal commented Sep 12, 2024

I was having some trouble ascertaining whether the default Caddyfile /etc/caddy/Caddyfile is used while using Laravel Octane, but I found it it's actually using a stubbed Caddyfile from the Octane repo.

This is still a bit misleading, as when you go to the stubbed Caddyfile it looks like you can use the environment variables that it has templated within it. This however doesn't work because when Octane boots up a process it will only add environment variables that are defined in this file. So, I also added a warning that env vars will not be respected when using Laravel Octane.

@dunglas dunglas merged commit b8e5ad1 into dunglas:main Oct 3, 2024
1 check passed
@dunglas
Copy link
Owner

dunglas commented Oct 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants