Fix unspecified "except:" blocks #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are bad since they catch every exception out there, including KeyboardInterrupt and the like. The first block is entirely removed as the two function call are not supposed to raise anything given legit parameters. The second should, according to the method description, only catch KeyError to change them into AttributeError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are bad since they catch every exception out there, including
KeyboardInterrupt and the like.
The first block is entirely removed as the two function call are not
supposed to raise anything given legit parameters.
The second should, according to the method description, only catch
KeyError to change them into AttributeError.