Make ProtocolUpgradeEnabled configurable #9598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgespalding
changed the title
georgespalding
force-pushed
the
add-protocolUpgradeEnabled
branch
from
ba224f9 to
afeded6
Compare
georgespalding
force-pushed
the
add-protocolUpgradeEnabled
branch
from
afeded6 to
8e3bb46
Compare
joschi
approved these changes
Nov 25, 2024
Member
joschi
left a comment
joschi
left a comment
There was a problem hiding this comment.
@georgespalding Thanks a lot for your contribution! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Closes #9597
The httpclient5.4 sends request headers
"connection: Upgradeandupgrade: TLS/1.2by default.When istio/envoy sees these headers the request is aborted with
response: "upgrade_failed"The httpclient5 can be configured to not do this, but there is no practical way to access that setting from dropwizard plumbing today.
This PR attempts to remedy that issue.
Solution:
Make
protocolUpgradeEnabledconfigurable on the HttpClientConfiguration.Result:
When
protocolUpgradeEnabledis set tofalse, it will allow the httpclient5 client to successfully interoperate with istio/envoy.