Fix object identity of ScheduledHealthCheck #9471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhowe
force-pushed
the
health-identity-fix
branch
from
8d560c8 to
26e3999
Compare
joschi
approved these changes
Nov 25, 2024
joschi
force-pushed
the
health-identity-fix
branch
from
26e3999 to
3652fb5
Compare
This was referenced Nov 25, 2024
The previouslyRecovered and type fields were not included in `equals`, `hashCode` or `toString` of ScheduledHealthCheck Take the opportunity to align the `toString` methods with other Dropwizard code, using string concatenation instead of `StringBuilder`.
auto-merge was automatically disabled
November 25, 2024 23:07
Head branch was pushed to by a user without write access
rhowe
force-pushed
the
health-identity-fix
branch
from
3652fb5 to
0c8e204
Compare
|
@joschi sorry I rebased it and clashed with your button clicking |
joschi
added a commit
that referenced
this pull request
Nov 25, 2024
The previouslyRecovered and type fields were not included in `equals`, `hashCode` or `toString` of ScheduledHealthCheck Take the opportunity to align the `toString` methods with other Dropwizard code, using string concatenation instead of `StringBuilder`. Refs #9471 (cherry picked from commit 3652fb5) Co-authored-by: Russell Howe <[email protected]>
joschi
added a commit
that referenced
this pull request
Nov 25, 2024
The previouslyRecovered and type fields were not included in `equals`, `hashCode` or `toString` of ScheduledHealthCheck Take the opportunity to align the `toString` methods with other Dropwizard code, using string concatenation instead of `StringBuilder`. Refs #9471 (cherry picked from commit 3652fb5) Co-authored-by: Russell Howe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previouslyRecovered and type fields were not included in
equals,hashCodeortoStringof ScheduledHealthCheckTake the opportunity to align the
toStringmethods with other Dropwizard code, using string concatenation instead ofStringBuilder.