Apply grammar suggestions from the IntelliJ linter #9469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
georgespalding
left a comment
georgespalding
left a comment
There was a problem hiding this comment.
Overall, an improvement
...izard-configuration/src/test/java/io/dropwizard/configuration/LevenshteinComparatorTest.java
Outdated
Show resolved
Hide resolved
georgespalding
approved these changes
Nov 11, 2024
Contributor
georgespalding
left a comment
georgespalding
left a comment
There was a problem hiding this comment.
LGTM. I'm not sure what the best practice is for this repo, the PR says "out of date with base branch" so perhaps rebase onto release/4.0.x?
rhowe
force-pushed
the
grammar-fixups
branch
from
70d8d8c to
5e23bc9
Compare
joschi
force-pushed
the
grammar-fixups
branch
from
5e23bc9 to
763ed2c
Compare
joschi
approved these changes
Nov 25, 2024
This was referenced Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
IntelliJ's linter identified a few grammatical gremlins
Solution:
Apply most of them