lib: mkdir_parents() - Avoid unnecessary syscalls when uid/gid doesn'…

…t change There's no need to open() + fchown() the directory after mkdir(), if neither uid nor gid changes.
dovecot · Nov 26, 2024 · e3bbaad · e3bbaad
1 parent 1d6f95c
commit e3bbaad
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/lib/mkdir-parents.c b/src/lib/mkdir-parents.c
@@ -25,6 +25,11 @@ mkdir_chown_full(const char *path, mode_t mode, uid_t uid,
 		umask(old_mask);
 		if (ret < 0)
 			break;
+		if (uid == (uid_t)-1 && gid == (gid_t)-1) {
+			/* no changes to owner/group */
+			return 0;
+		}
+
 		fd = open(path, O_RDONLY);
 		if (fd != -1)
 			break;