I'm guessing you couldn't find a good precompiler based solution instead of writing the filename in every SS2K_LOG() call?

I see a possible way of doing it but it looks like it's runtime, so yuck...

https://stackoverflow.com/questions/8487986/file-macro-shows-full-path

Got through a bunch of it tonight. I'll continue in the morning.

One concern - is there a switch for logging to Spiffs? It's probably pretty crappy flash memory and might wear out if we do a lot of writes.

Also, I don't know yet if you have any space checking before you append to the file (don't want to fill up spiffs).

Another thing I just thought of, if the file gets very large, I read somewhere that spiffs write appends can get very slow (like tens of seconds) if the file gets more than a few kb in size.

espressif/arduino-esp32#1360

@doudar I’m not logging to SPIFFS and didn’t plan to support that.

Looks like there's a crash when a shift happens.

Any updates?

Progress 👍

I'm studying tonight - review will happen tomorrow.

Have you done any ride testing yet?

Lgtm

@kadaan Make sure to restore this branch (it's in your repo so I can't).

I obviously love the output but I didn't pay attention previously to the lengthy process involved to generate logging in the BLE_Server code. It would be too laborious and obscure to insert the proposed logging into every case statement for the soon to be incoming FTMS_Server-fillout as well as future changes.

We need to get

  const int kLogBufMaxLength = 200;
  char logBuf[kLogBufMaxLength];
  int logBufLength = ss2k_log_hex_to_buffer(ftmsIndoorBikeData, *(&ftmsIndoorBikeData + 1) - ftmsIndoorBikeData, logBuf, 0, kLogBufMaxLength);
  logBufLength += snprintf(logBuf + logBufLength, kLogBufMaxLength - logBufLength, "-> %s | %s | FTMS(IBD)[", FITNESSMACHINESERVICE_UUID.toString().c_str(),
                           fitnessMachineIndoorBikeData->getUUID().toString().c_str());
  logBufLength += snprintf(logBuf + logBufLength, kLogBufMaxLength - logBufLength, " HR(%d)", hr % 1000);
  logBufLength += snprintf(logBuf + logBufLength, kLogBufMaxLength - logBufLength, " CD(%.2f)", fmodf(cadRaw, 1000.0));
  logBufLength += snprintf(logBuf + logBufLength, kLogBufMaxLength - logBufLength, " PW(%d)", watts % 10000);
  logBufLength += snprintf(logBuf + logBufLength, kLogBufMaxLength - logBufLength, " SD(%.2f)", fmodf(speed, 1000.0));
  strncat(logBuf + logBufLength, " ]", kLogBufMaxLength - logBufLength);
SS2K_LOG("BLE_Server", "%s", logBuf);

Shortened to:

SS2K_LOG("BLE_Server", " %s -> %s | %s | FTMS(IBD)[ HR(%d) CD(%.2f) PW(%d) SD(%.2f) ]", ss2k_log_hex_to_buffer(ftmsIndoorBikeData), hr % 1000, fmodf(cadRaw, 1000.0), watts % 10000, fmodf(speed, 1000.0));

Please let me know where I can help, but this one is a pretty complex problem (for me).