Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for semver_range #164

Merged
merged 3 commits into from
May 25, 2024
Merged

Conversation

icnocop
Copy link
Collaborator

@icnocop icnocop commented May 24, 2024

Fixes #163

Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the new library doing the same/similar thing as semver200? Does this need to be refactored into one?

@icnocop
Copy link
Collaborator Author

icnocop commented May 24, 2024

Unfortunately, issue easz/cpp-semver#9 prevents us from replacing semver200 because the test DVLib::UnitTests::VersionUtilUnitTests::testCompareSemanticVersion fails for the test data { L"1.0.0-beta.2", L"1.0.0-beta.11", -1 }.

@dblock
Copy link
Collaborator

dblock commented May 24, 2024

Unfortunately, issue easz/cpp-semver#9 prevents us from replacing semver200 because the test DVLib::UnitTests::VersionUtilUnitTests::testCompareSemanticVersion fails for the test data { L"1.0.0-beta.2", L"1.0.0-beta.11", -1 }.

Should we wait/fix? I don't love that we have two libraries. WDYT?

@icnocop
Copy link
Collaborator Author

icnocop commented May 24, 2024

I also tried https://github.com/Neargye/semver but existing tests also fail because of these issues:
Neargye/semver#6
Neargye/semver#23

@icnocop
Copy link
Collaborator Author

icnocop commented May 24, 2024

https://github.com/mariokonrad/semver / https://gitlab.com/mariokonrad/semver passes all the tests, so I will update this PR using that code instead.

@dblock dblock merged commit c39c74d into dotnetinstaller:master May 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installed check operators do not check against the same input to satisfy multiple conditions
2 participants