Updated C# projects to CPS/SDK-style format #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted packages.config to package references Removed unused using statements Replaced local copy of StyleCop and NUnit with NuGet packages Using MSBuild to restore nuget packages instead of nuget.exe
|
I've been experiencing random crashes from htmlInstaller.exe, especially during test runs on the build agents. The crash dumps, attached within build artifacts, indicate a stack trace originating from htmllayout.dll. I've been trying to migrate from HtmlLayout to Sciter.JS but that is still work in progress (and not part of this PR). As a work-around, re-running the build may not cause a crash. You can see the same code builds and tests pass successfully: |
|
I would like this PR merged before working on any new issues, like #163 for example. |
|
Looks good, did a cursory look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted packages.config to package references
Removed unused using statements
Replaced local copy of StyleCop and NUnit with NuGet packages Using MSBuild to restore nuget packages instead of nuget.exe