Fix go-to-def on an abstract explicit impl of an interface method #76238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@ToddGrun ptal |
ToddGrun
reviewed
Dec 6, 2024
| @@ -266,8 +266,7 @@ public readonly void Goo1() { } | |||
| [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/70232")] | |||
| public async Task TestMissingWhenAlreadyContainingImpl() | |||
| { | |||
| await TestMissingAsync( | |||
| """ | |||
| await TestInRegularAndScriptAsync(""" | |||
There was a problem hiding this comment.
Good point. Well fix in follow-up. The original tray was just validating no crash. The actual behavior is fine either way.
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61268