Improved the grammar of local functions #20368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
approved these changes
Jun 21, 2017
| + ; | ||
|
|
||
| +local-function-body | ||
| +local_function_body |
There was a problem hiding this comment.
❓ Does this rule not already exist with another name we can/should use?
There was a problem hiding this comment.
There is method_body, but it also allows empty body (';'; for abstract, extern and partial methods), so it's not the same and I think it shouldn't be used here.
Also, it looks like arrow_expression_body does not exist.
There was a problem hiding this comment.
Yes, arrow_expression_body is referenced from some new specs even though it hasn't made its way into the language yet.
sharwell
added
Community
agocke
reviewed
Jun 22, 2017
| + ; | ||
|
|
||
| +local-function-modifiers | ||
| + : (async | unsafe) |
There was a problem hiding this comment.
That's the style used by the spec. I think it makes sense to stay consistent with it.
agocke
approved these changes
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes I made:
asyncandunsafecan be both used at the same time.