Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProductInfoHeaderValue.xml #7319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update ProductInfoHeaderValue.xml #7319

wants to merge 1 commit into from

Conversation

wenz
Copy link
Contributor

@wenz wenz commented Oct 24, 2021

Summary

Taking a shot at better describing System.Net.Http.Headers.ProductInfoHeaderValue

Fixes #3274

@wenz wenz requested a review from a team as a code owner October 24, 2021 07:58
@ghost
Copy link

ghost commented Oct 24, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

Taking a shot at better describing System.Net.Http.Headers.ProductInfoHeaderValue

Fixes #3274

Author: wenz
Assignees: -
Labels:

area-System.Net

Milestone: -

@opbld33
Copy link

opbld33 commented Oct 24, 2021

Docs Build status updates of commit ba429fb:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http.Headers/ProductInfoHeaderValue.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@@ -44,7 +44,7 @@
<format type="text/markdown"><![CDATA[

## Remarks
The <xref:System.Net.Http.Headers.ProductInfoHeaderValue> class provides support for the product and comment tokens values used in a User-Agent header as defined in [RFC 2616](https://go.microsoft.com/fwlink/?LinkID=241642) by the IETF.
The <xref:System.Net.Http.Headers.ProductInfoHeaderValue> class provides support for the product and comment tokens values used in a User-Agent header as defined in [RFC 2616](https://go.microsoft.com/fwlink/?LinkID=241642) by the IETF.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why link it as fwlink?
Also 2616 has been obsoleted, twice already, the newest RFC is here: https://www.rfc-editor.org/rfc/rfc9110#field.user-agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document ProductInfoHeaderValue constructors
3 participants