This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Remove Microsoft.Windows.Compatibility.Shims package #36644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericstj
reviewed
Apr 5, 2019
ericstj
reviewed
Apr 5, 2019
ericstj
approved these changes
Apr 6, 2019
stephentoub
approved these changes
Apr 6, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…6644) * Remove Microsoft.Windows.Compatibility.Shims package * PR Feedback Commit migrated from dotnet/corefx@f61f497
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to do this anymore since starting 2.1, we use the inbox shipped shims. So if people want the latest shims, they should just move to latest frameworks. If we want to ship the latest shims for 2.0, we would need to also cross compile the shims for 2.1 and so on for newer frameworks. @ericstj and I decided it is not worth, and if we need to ship a fix to the shims package we can do it from the 2.1 branch.
cc: @jkotas @ericstj @danmosemsft @Anipik