This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Moved Interop Locations For System.IO.Compression.Brotli #36614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to the stacktraces both checks fail during testing of System.Text.Json.Tests, not quite sure what the next step would be. Is there a way to rerun the tests? |
stephentoub
reviewed
Apr 6, 2019
src/System.IO.Compression.Brotli/src/System.IO.Compression.Brotli.csproj
Outdated
Show resolved
Hide resolved
https://github.com/dotnet/corefx/issues/36618 I've run them again. (you can use the azp command): https://github.com/dotnet/corefx/blob/34118b74d46129b3095e1b4dbad8441c4db62e33/Documentation/project-docs/pullrequest-builds.md#azure-pipelines-commands |
|
Thanks @ahsonkhan , it's good to know these kind of test errors can occur between different builds and to treat it like a possible issue. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…fx#36614) * MovedInteropLocationForBrotli * Combined Brotli Files Commit migrated from dotnet/corefx@e5fddbc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to relocate the project's interop definitions into the Common library project.