This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfurt
added
the
* NO MERGE *
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Apr 2, 2019
wfurt
added
area-Infrastructure-libraries
and removed
* NO MERGE *
The PR is not ready for merge yet (see discussion for detailed reasons)
labels
Apr 8, 2019
user build was able to execute tests (with incorrect queue name) |
MattGal
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just checking... is the "build on 3.7, run on 3.8" intentional, and should it also be run on 3.9?
Alpine 3.9 is not quite stable yet. I did not want to create more noise. |
safern
reviewed
Apr 8, 2019
safern
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just fix the extra line comment please 😄
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* try to add Alpine ARM64 queue * remove extra line * correct queue names * update queues * use open queue for CI * final cleanup * feedback from review Commit migrated from dotnet/corefx@37867bd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Alpine ARM64 queue to official build runs.