Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Fix Debug.Assert in GenericDelegateCache #23755

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Fix Debug.Assert in GenericDelegateCache #23755

merged 1 commit into from
Apr 5, 2019

Conversation

safern
Copy link
Member

@safern safern commented Apr 5, 2019

The Debug.Assert is not matching what we're casting the value to, nor the generic parameters. Causing the JIT Perf tests to fail in the PR to merge to master:

Assertion Failed

   at System.Threading.Tasks.GenericDelegateCache`2.<>c.<.cctor>b__4_2(Task`1 wrappedAntecedents, Object state)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.<>c.<.cctor>b__274_0(Object obj)
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
   at System.Threading.Tasks.Task.ExecuteEntryUnsafe(Thread threadPoolThread)
   at System.Threading.Tasks.Task.ExecuteFromThreadPool(Thread threadPoolThread)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()

cc: @stephentoub @danmosemsft

@stephentoub stephentoub merged commit bd05029 into dotnet:NullableFeature Apr 5, 2019
@safern safern deleted the FixAssertFutureFactory branch April 5, 2019 01:38
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this pull request Apr 5, 2019
@safern @dotnet-bot
Fix Debug.Assert in GenericDelegateCache (dotnet/coreclr#23755)
cc0d826 
Signed-off-by: dotnet-bot <[email protected]>
stephentoub pushed a commit to dotnet/corefx that referenced this pull request Apr 6, 2019
@safern @stephentoub
Fix Debug.Assert in GenericDelegateCache (dotnet/coreclr#23755)
192abb3 
Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Apr 9, 2019
@safern @Anipik
Fix Debug.Assert in GenericDelegateCache (dotnet/coreclr#23755)
f845535 
Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Apr 9, 2019
@safern @Anipik
Fix Debug.Assert in GenericDelegateCache (dotnet/coreclr#23755)
2dc5396 
Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/mono that referenced this pull request Apr 9, 2019
@safern @Anipik
Fix Debug.Assert in GenericDelegateCache (dotnet/coreclr#23755)
ebe0d57 
Signed-off-by: dotnet-bot <[email protected]>
Anipik pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Apr 9, 2019
@safern @Anipik
Fix Debug.Assert in GenericDelegateCache (dotnet/coreclr#23755)
3025ff5 
Signed-off-by: dotnet-bot <[email protected]>
jkotas pushed a commit to dotnet/corert that referenced this pull request Apr 10, 2019
@safern @jkotas
Fix Debug.Assert in GenericDelegateCache (dotnet/coreclr#23755)
42d2c27 
Signed-off-by: dotnet-bot <[email protected]>
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@safern @stephentoub
Fix Debug.Assert in GenericDelegateCache (dotnet/coreclr#23755)
6fc5838 
Commit migrated from dotnet/coreclr@bd05029
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@safern @stephentoub