Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add verifyAddrsByAccount method on DotBit #55

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

tianxiemaochiyu
Copy link
Contributor

No description provided.

@tianxiemaochiyu tianxiemaochiyu added the enhancement New feature or request label Jul 6, 2023
@tianxiemaochiyu tianxiemaochiyu requested a review from web3max July 6, 2023 10:15
@tianxiemaochiyu tianxiemaochiyu self-assigned this Jul 6, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jul 6, 2023

PR Summary

  • Introduction of a new verifyAddrsByAccount method to dotbit.md
    This update introduces a new functionality into the system. It allows verification to see if a given address possesses a specified SubDID under a certain account.

  • Added verifyAddrsByAccount function in DotBit.ts
    We have expanded our code in DotBit.ts by implementing the verifyAddrsByAccount function. This function communicates with the subAccountVerify function in BitIndexer.ts to enable the address verification process mentioned above.

  • Enabling address verification in BitIndexer.ts via subAccountVerify
    Following up on the last item, we introduced the subAccountVerify function in BitIndexer.ts. This function forms the backbone of the address verification process. It checks if an address holds a specified SubDID under a particular account.

  • Testing the verifyAddrsByAccount function
    Finally, we've introduced tests for the verifyAddrsByAccount method in DotBit.test.ts. These tests ensure that the new function performs correctly and helps us maintain the reliability of our project.

@web3max web3max merged commit 8495d5d into main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants