Run static analysis with language level PHP 8.1 #9314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
sa/language-level-8.1
branch
from
4ca192f
to
4446eae
Compare
greg0ire
approved these changes
Jan 2, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 2, 2022
* 2.10.x: Run static analysis with language level PHP 8.1 (doctrine#9314) Document PHPUnit mocks with intersection types (doctrine#9318)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 2, 2022
* 2.10.x: Run static analysis with language level PHP 8.1 (doctrine#9314) Document PHPUnit mocks with intersection types (doctrine#9318)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 2, 2022
* 2.11.x: Run static analysis with language level PHP 8.1 (doctrine#9314) Document LockMode enums (doctrine#9319) Document PHPUnit mocks with intersection types (doctrine#9318) Run PHP CodeSniffer on PHP 8.1 (doctrine#9317) Psalm 4.17.0 (doctrine#9315) Run static analysis on PHP 8.1 (doctrine#9310)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #9310
While PHP 7.1 is the lowest supported version, the repository contains features that require a more recent PHP version and we are currently hardly able to run static analysis on those parts.
Letting the static analysis tools operate on PHP 7.1 as language level causes unnecessary pain and barely spots real issues. Especially Psalm has a history of reporting funny errors if the dependencies are on a higher language level. I'd suggest to let the test suite cover PHP 7.1 support and let the SA tools operate on PHP 8.1 instead.