Add DQL non-ASCII characters support #9269
Conversation
|
Hello, just saw this PR and wandering if all RDBS support non ASCII characters like in your test ? Just like not using non ASCII characters in code, I've been always told to avoid non ASCII characters in database |
|
I tested this with MySQL and had no issue so far. I don't know about other vendors. But DQL is about PHP classes and properties. Even if they use non-ASCII characters, you can still map them to ASCII tables and columns names. |
julienfalque
force-pushed
the
dql-non-ascii
branch
2 times, most recently
from
9e22e7d
to
ed3e79f
Compare
|
You can use integration tests to test your changes in form of an SQL with the different databases. |
julienfalque
force-pushed
the
dql-non-ascii
branch
from
ed3e79f
to
121354a
Compare
|
@SenseException I added a test but I don't know if it passes with all platforms, can you please run GitHub Actions workflows? |
Apparently, MySQL does not like what you did. 😕 |
|
Yeah, I said I tested this with MySQL but it was MariaDB actually 😅️. I'm investigating the failures. |
julienfalque
force-pushed
the
dql-non-ascii
branch
2 times, most recently
from
82e704c
to
0bdf067
Compare
julienfalque
force-pushed
the
dql-non-ascii
branch
2 times, most recently
from
855f184
to
1b92050
Compare
|
Are you still pursuing this @julienfalque ? |
|
I need to rebase and fix conflicts. Hopefully tests will still pass. |
julienfalque
force-pushed
the
dql-non-ascii
branch
from
1b92050
to
bc455fd
Compare
|
Just rebased. Can a maintainer approve running workflows please? |
julienfalque
force-pushed
the
dql-non-ascii
branch
from
bc455fd
to
5c5aa91
Compare
|
Sorry, didn't notice the PR still targeted unmaintained branch |
julienfalque
force-pushed
the
dql-non-ascii
branch
from
5c5aa91
to
1c3f74c
Compare
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
|
I don't actually need this anymore but I would still like to see it merged. |
|
I assume the next target branch for this would be |
|
We don't accept new features on 2.x unless they improve forward compatibility the proper target is 3.4 |
This PR adds support for non-ASCII characters usage in DQL.
My use case was to use the actual domain experts language in the code (french, so with some diacritics) instead of translating everything to english. The only obstable I faced was non-ASCII characters not being parsed correctly in DQL, though I only tried a few simple scenarios.
I don't know if not supporting non-ASCII characters was on purpose. If so, feel free to close this PR.
The provided naming strategies also need an update but I will do that in a subsequent PR if this one is accepted.