Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Events::onFlush and PostFlush() documentation: events are always raised #11709

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix Events::onFlush and PostFlush() documentation: events are always raised #11709

merged 1 commit into from
Nov 18, 2024

Conversation

lyrixx
Copy link
Contributor

@lyrixx lyrixx commented Nov 7, 2024 •
edited
Loading

Improvement

Q A
New Feature no
RFC no
BC Break no

Summary

see

orm/src/UnitOfWork.php

Lines 399 to 413 in 9e2bfa8

if (
! ($this->entityInsertions ||
$this->entityDeletions ||
$this->entityUpdates ||
$this->collectionUpdates ||
$this->collectionDeletions ||
$this->orphanRemovals)
) {
$this->dispatchOnFlushEvent();
$this->dispatchPostFlushEvent();
$this->postCommitCleanup($entity);
return; // Nothing to do.
}

@greg0ire greg0ire added this to the 2.20.1 milestone Nov 18, 2024
@greg0ire greg0ire merged commit 58ad1d9 into doctrine:2.20.x Nov 18, 2024
75 checks passed
@greg0ire
Copy link
Member

Thanks @lyrixx !

@lyrixx lyrixx deleted the fix-event-doc branch November 18, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire greg0ire approved these changes

@beberlei beberlei Awaiting requested review from beberlei

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
2.20.1
Development

Successfully merging this pull request may close these issues.
3 participants
@lyrixx @greg0ire @SenseException