Change the lock mode in the "Aggregate Fields" cookbook (aggregate-fields.rst) article. #11344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `PESSIMISTIC_READ` to `PESSIMISTIC_WRITE`. Otherwise, the solution to the race condition at the bottom of the article would allow concurrent reads, which would not solve the presented race condition problem.
greg0ire
previously approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Looks consistent with https://www.doctrine-project.org/projects/doctrine-orm/en/3.1/reference/transactions-and-concurrency.html#pessimistic-locking, which mentions that write acts at the database level. It's not completely clear at what level read acts. I'd check the implementation if I wasn't on my phone.
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
SenseException
approved these changes
Oct 23, 2024
|
Thanks @d-ph ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
PESSIMISTIC_READtoPESSIMISTIC_WRITEbecause otherwise the solution to the race condition at the bottom of the article would allow concurrent reads, which would not solve the presented race condition problem.Please correct me if I'm wrong because I might be.