Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psalm 5.22.2 #11326

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Psalm 5.22.2 #11326

merged 1 commit into from
Mar 1, 2024

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Mar 1, 2024

I've bumped Psalm and regenerated the baseline.

Apparently, the baseline format has changed again (<![CDATA[]]> all the things now, apparently) which is why the diff is pretty huge. Also, some errors regarding nullability have been reclassified.

Then there's a new rule called RiskyTruthyFalsyComparison which bombs in our codebase. I've disabled it because I don't believe these errors are worth fixing on 2.x. We can think about enabling it in 3.x though.

@derrabus derrabus requested a review from greg0ire March 1, 2024 09:17
@derrabus derrabus added this to the 2.18.2 milestone Mar 1, 2024
@derrabus derrabus merged commit 52a6a21 into doctrine:2.18.x Mar 1, 2024
58 checks passed
@derrabus derrabus deleted the bump/psalm branch March 1, 2024 09:47
derrabus added a commit that referenced this pull request Mar 1, 2024
* 2.18.x:
  Psalm 5.22.2 (#11326)
derrabus added a commit to derrabus/orm that referenced this pull request Mar 1, 2024
derrabus added a commit to derrabus/orm that referenced this pull request Mar 1, 2024
derrabus added a commit to derrabus/orm that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants