Run tools on PHP 8.2 #10287
Merged
Run tools on PHP 8.2 #10287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Dec 10, 2022
derrabus
force-pushed
the
bump/php-8.2-tools
branch
from
2ff18a0
to
58faf8b
Compare
greg0ire
previously approved these changes
Dec 10, 2022
|
This needs to be updated as well I think: Line 11 in b391431 |
derrabus
force-pushed
the
bump/php-8.2-tools
branch
from
58faf8b
to
93d1608
Compare
|
Of course, done. |
derrabus
commented
Dec 11, 2022
| message: "#^Access to an undefined property Doctrine\\\\ORM\\\\Query\\\\AST\\\\Node\\:\\:\\$pathExpression\\.$#" | ||
| count: 1 | ||
| path: lib/Doctrine/ORM/Query/SqlWalker.php | ||
|
|
There was a problem hiding this comment.
I have no idea why this error suddenly appears when I bump the language level. But it's valid anyway.
greg0ire
approved these changes
Dec 11, 2022
michnovka
pushed a commit
to michnovka/orm
that referenced
this pull request
Dec 11, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Dec 12, 2022
* 2.13.x: Fix changeset computation for enum arrays (doctrine#10277) Psalm 5.2.0 (doctrine#10291) Run tools on PHP 8.2 (doctrine#10287)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Dec 12, 2022
* 2.14.x: Fix changeset computation for enum arrays (doctrine#10277) Psalm 5.2.0 (doctrine#10291) Run tools on PHP 8.2 (doctrine#10287)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows doctrine/.github#35