Add $not constructor parameter to AST classes
#10267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/ast-not-constructor
branch
from
d9b850a
to
59d612b
Compare
greg0ire
approved these changes
Dec 5, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Dec 5, 2022
* 2.14.x: Add $not constructor parameter to AST classes (doctrine#10267)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Dec 5, 2022
* 2.14.x: Add $not constructor parameter to AST classes (doctrine#10267)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #10219, I noticed the inconsistent typing of negation flags (
$not) on various AST classes. In most cases, we populate$someAstExpression->notright after construction the object. In some cases, we don't assign any value to it, but assume it to befalseafterwards.With all those public properties, I think we should aim at making all those classes immutable in 3.0. Adding
$notto constructors is a first step in that direction. I've also split theInExpressionclass into two classes because it actually covers two distinct cases that we need to distinguish whenever we deal with an instance of that class.