Skip to content

fix: enhancement of isExternal #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sy-records merged 2 commits into from
Jun 18, 2023
Merged

fix: enhancement of isExternal #2093

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bba3ca5
fix: Enhancement of isExternal
sy-records Jun 16, 2023
942a162
test: add test for isExternal
sy-records Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add test for isExternal
  • Loading branch information
@sy-records
sy-records committed Jun 17, 2023
commit 942a162d2f91019c01065d5ffb03cfb94b7e020c
12 changes: 12 additions & 0 deletions test/unit/core-util.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,17 @@ describe('core/util', () => {

expect(result).toBeTruthy();
});

test('external url with one \\', () => {
const result = isExternal('/\\example.github.io/docsify/demo.md');

expect(result).toBeTruthy();
});

test('external url with two \\', () => {
const result = isExternal('/\\\\example.github.io/docsify/demo.md');

expect(result).toBeTruthy();
});
});
});