Skip to content

Conversation

@jhildenbiddle
Copy link
Member

  • Rename “Showcases” to “Showcase”
  • Rename “Custom themes” to “Themes”
  • Add docsify-themeable the Themes section
  • Remove non-usable entries from Themes section

- Rename “Showcases” to “Showcase”
- Rename “Custom themes” to “Themes”
- Add docsify-themeable the Themes section
- Remove non-usable entries from Themes section
@QingWei-Li QingWei-Li merged commit 3f5e0a8 into docsifyjs:master Jun 7, 2018
@jhildenbiddle
Copy link
Member Author

Hello, @QingWei-Li !

I am the creator of docsify-themeable, which is a theme system for docsify.js. As detailed above, I'd like to propose a few changes to the awesome-docsify list.

The main thing I wanted to propose is removing the "non-usable" items from the "Themes" section. Before my edits, the themes section looked like this:

## Custom theme

* [commitlint](http://marionebl.github.io/commitlint/#/)
* [style-dictionary](https://amzn.github.io/style-dictionary/#/)
* [Noty](http://ned.im/noty/)
* [JS MythBusters](https://mythbusters.js.org)

The rational for removing these items is:

  1. None of these entires provide a theme that docsify users can add to their own site.
  2. These items are already listed under the "Showcase" section
  3. Mixing showcase sites (previous entries) with themes users can add to their site (docsify-themeable) will likely confuse users.

I wanted to explain the rational so my edits weren't interpretted as removing other projects to draw more attention to my own. That isn't to case. My goal is to make it clear that the "Themes" section contains themes users can add to their own projects, much like the "Plugins" section above it.

Thanks for considering the change, and keep up the great work with docsify! As you can see, I'm clearly a fan! 😄

@jhildenbiddle
Copy link
Member Author

Ha! Looks like you merged the change before I finished my message!

Thanks, @QingWei-Li. Very much appreciated!

@QingWei-Li
Copy link
Member

Thanks @jhildenbiddle

Sorry I didn't have time to maintain recently. I was interviewing for the last few weeks. I will be back when I find a job.

@jhildenbiddle
Copy link
Member Author

No problem. Sorry for the barrage of issues I added tonight. I just made a list as I was building docsify-themeable. Now that it's been launched, I dumped all of the issues into the docsify repo.

FWIW, I am more than willing to dive in and help with the issues I created. I'm a little swamped at the moment, but in the coming weeks I'll check back in and see where I can help.

Until then, goo luck with the job search!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants