Use io.copy for build context compression #5719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5719 +/- ##
=======================================
Coverage 59.52% 59.52%
=======================================
Files 346 346
Lines 29381 29381
=======================================
Hits 17488 17488
Misses 10923 10923
Partials 970 970 |
Benehiko
approved these changes
Jan 3, 2025
|
Ah! Thanks; missed that you opened a PR (we were discussing this during the maintainers call yesterday) Let me do a quick push to fix the vendor issue |
The use of pools here is unnecessary and creates a code dependency on moby library which will move to internal. The pool does not provide any value here since it is only done for a single operation and unlikely performed in alongside other operations which are re-using the buffers many times between garbage collections. Signed-off-by: Derek McGowan <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
build-context-io-copy
branch
from
a8d1b43 to
7b37f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of pools here is unnecessary and creates a code dependency on moby library which will move to internal.
The pool does not provide any value here since it is only done for a single operation and unlikely performed alongside other operations which are re-using the buffers many times between garbage collections.