Nested variables interpolation in compose files #4268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbsgilbs
force-pushed
the
nested-variables-interpolation
branch
from
b097548 to
7080418
Compare
gilbsgilbs
changed the title
gilbsgilbs
force-pushed
the
nested-variables-interpolation
branch
2 times, most recently
from
634f872 to
2a8f9b3
Compare
This allows for nested variables interpolation. Fixes docker#4265 Signed-off-by: N. Le Roux <[email protected]>
Signed-off-by: N. Le Roux <[email protected]>
gilbsgilbs
force-pushed
the
nested-variables-interpolation
branch
2 times, most recently
from
6e726c6 to
df232bd
Compare
|
I just rebased this PR as apparently this is still an issue: #4265 (comment) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix nested variables interpolation in compose files which should be allowed as per compose specification.
- How I did it
Use compose-go for variables interpolation in compose files instead of the current implementation.
I've also considered copying the code from compose-go as it is very similar to the existing implementation (and was probably initially copied from this project), but I assumed it would be better to use the reference implementation. Feel free to tell me if you don't want to add this new dependency.
- How to verify it
Run the test suite with/without the fix, or use the repro described in #4265
- Description for the changelog
Fix nested variables interpolation in compose files.
- A picture of a cute animal (not mandatory but encouraged)
Fixes #4265