Add Okta support #675
Merged
Add Okta support #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setu4993
force-pushed
the
feature/oauth_okta
branch
4 times, most recently
from
0c85030 to
2422bc4
Compare
setu4993
force-pushed
the
feature/oauth_okta
branch
2 times, most recently
from
cfa25b8 to
e6a1b94
Compare
setu4993
force-pushed
the
feature/oauth_okta
branch
from
f74586e to
e807089
Compare
|
Hi @Hironsan, @c-w, @icoxfog417, please review this when you have a chance. The code quality failing CI is from the test where it assumes there's a hard-coded password or secret. |
c-w
reviewed
Jul 19, 2020
|
Thanks for the review and feedback, @c-w. I've updated the PR based on your comments, and the CI build is also passing. |
setu4993
force-pushed
the
feature/oauth_okta
branch
from
5efe1bb to
8258ec6
Compare
c-w
approved these changes
Jul 20, 2020
setu4993
force-pushed
the
feature/oauth_okta
branch
from
8258ec6 to
68fdfb2
Compare
|
Is this WIP or finished? |
|
@Hironsan : Hi, this is finished and ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time-contributor and working with OAuth / Django. I took inspiration from #75 but I probably missed some things. Would appreciate some help on the tests to add, and missing changes required.
Resolves #674.