Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Okta Login for newer versions of Doccano #2079

Merged
merged 9 commits into from
Dec 9, 2022

Conversation

lhr0909
Copy link

@lhr0909 lhr0909 commented Dec 3, 2022

We have been working on a version that allows Okta Login, which should resolve #1255 . Would need a bit of guidance to clean up this PR in order to merge it. Cheers!

@lhr0909 lhr0909 changed the title Added Okta Login Added Okta Login for newer versions of Doccano Dec 3, 2022
@Hironsan
Copy link
Member

Hironsan commented Dec 5, 2022

Thanks! LGTM.

Could you please write how to use this feature?

@Hironsan Hironsan merged commit a2918f7 into doccano:master Dec 9, 2022
@setu4993
Copy link
Contributor

Thanks a ton for working on this, @lhr0909!

@georgeseifada
Copy link

georgeseifada commented Feb 21, 2023

Hi there.

I see that the latest released version of Doccano is 1.8.3 on December 8. But this PR was merged on December 9. How can I leverage this new feature when running Doccano via the docker container?

Update: It looks like the change was pushed in this action to the nightly tag. Is there any way to get the changes frozen to a specific tag / release?

@georgeseifada
Copy link

Update 2: I was able to build the proper image by checking out a specific commit. However, I'm running into an issue where Origin is being set to null in the headers and thus failing the authentication with a 403 error. Are the any settings I need to change to resolve this?

@lhr0909
Copy link
Author

lhr0909 commented Feb 22, 2023

@georgeseifada Hey, we discover an issue with the implementation and resolved it in our branch. Haven't gotten around to pushing it yet. But I will make sure we put together an updated PR for this.

@georgeseifada
Copy link

Thanks @lhr0909! Please share it here once ready. I'm excited for it 💯

@setu4993
Copy link
Contributor

+1, thanks, @lhr0909! Looking forward to the fixes. (I ran into the same issues with building the container locally a few months ago.)

Are the fixes the same as the ones in this diff? Or is something missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Okta OIDC social login is not available
5 participants