Fix scalar coercion (#1914) #1929
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #1914, where scalar values (int, float, complex, bool, np.number) were not correctly coerced into NdArray or JaxArray. PR adds a complete test suite ensuring correct behavior for all scalar types
Root Cause:
np.ndarray(value) and jnp.ndarray(value) interpret numeric values as shapes, not as data. This resulted in:
-uninitialized arrays when value was an integer
-validation errors when value was a float
-no coercion for complex or boolean scalars
1. Updated NdArray validator
2. Updated JaxArray validator
3. New Tests added in test_ndarray.py
test_from_scalar_int
test_from_scalar_float
test_from_scalar_complex
test_from_scalar_bool
test_from_scalar_in_document
These tests confirm:
Scalars convert to (1,) shape, Values are preserved correctly , Dtypes are correct (int32/int64, float32/float64, complex, bool) ,Scalars work correctly when assigned as Document fields