Skip to content

Conversation

@jay-bhambhani
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 27.97428% with 224 lines in your changes missing coverage. Please review.

Project coverage is 63.15%. Comparing base (82d7cee) to head (f9d56be).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
docarray/index/backends/opensearchv2.py 27.36% 223 Missing ⚠️
docarray/index/__init__.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1915       +/-   ##
===========================================
+ Coverage   29.01%   63.15%   +34.14%     
===========================================
  Files         136      137        +1     
  Lines        9468     9782      +314     
===========================================
+ Hits         2747     6178     +3431     
+ Misses       6721     3604     -3117     
Flag Coverage Δ
docarray 63.15% <27.97%> (+34.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jay-bhambhani
Copy link
Contributor Author

#1917

@JoanFM
Copy link
Member

JoanFM commented Feb 27, 2025

Hello @jay-bhambhani ,

Thanks for this contribution.

I would need you to sign the DCO for this to be accepted. Can you check our guidelines.

@jay-bhambhani jay-bhambhani force-pushed the feat_opensearch_integration branch from ed98b77 to 914d648 Compare March 1, 2025 00:37
@jay-bhambhani
Copy link
Contributor Author

thanks @JoanFM ! sorry i was still in the process of getting tests to pass - i 'm almost done cleaning up and this should be good for real review!

rename files and make some other fixes

missed the pytest marks

pytest marker

one more spot?

test

undo docker for local testing

fixes and cleanup

Signed-off-by: Jay Bhambhani <[email protected]>

fixup pyproject.toml

Signed-off-by: Jay Bhambhani <[email protected]>
@jay-bhambhani jay-bhambhani force-pushed the feat_opensearch_integration branch from 914d648 to 4124812 Compare March 1, 2025 00:41
@jay-bhambhani jay-bhambhani requested a review from JoanFM March 1, 2025 00:41
@jay-bhambhani
Copy link
Contributor Author

hi @JoanFM! if i run poetry update it tends to hang. is there a fix for this?

@jay-bhambhani
Copy link
Contributor Author

@JoanFM can i please ask for some help with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants