Skip to content

MongoDB Atlas: Two line change to make our CI builds green #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 2 commits into from
Sep 30, 2024
Merged

MongoDB Atlas: Two line change to make our CI builds green #1910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31b0ea9
Increased default retries
caseyclements Sep 30, 2024
468841d
Improved handling of filters
caseyclements Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docarray/index/backends/mongodb_atlas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,16 +563,18 @@ def _vector_search_stage(
max_candidates = self._get_max_candidates(search_field)
query = query.astype(np.float64).tolist()

return {
stage = {
'$vectorSearch': {
'index': search_index_name,
'path': search_field,
'queryVector': query,
'numCandidates': min(limit * oversampling_factor, max_candidates),
'limit': limit,
'filter': {"$and": filters} if filters else None,
}
}
if filters:
stage['$vectorSearch']['filter'] = {"$and": filters}
return stage

def _text_search_stage(
self,
Expand Down
2 changes: 1 addition & 1 deletion tests/index/mongo_atlas/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class FlatSchema(BaseDoc):
embedding2: NdArray = Field(dim=N_DIM, index_name="vector_index_2")


def assert_when_ready(callable: Callable, tries: int = 5, interval: float = 2):
def assert_when_ready(callable: Callable, tries: int = 10, interval: float = 2):
"""
Retry callable to account for time taken to change data on the cluster
"""
Expand Down