Skip to content

ci: fix some ci #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 1 commit into from
Jun 6, 2024
Merged

ci: fix some ci #1893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/add_license.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v3
with:
python-version: 3.10
python-version: "3.10"

- name: Run add_license.sh and check for changes
id: add_license
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
- name: Test
id: test
run: |
poetry run pytest -m "not (tensorflow or benchmark or index or jax)" --cov=docarray --cov-report=xml ${{ matrix.test-path }} --ignore=tests/integrations/store/test_jac.py
poetry run pytest -m "not (tensorflow or benchmark or index or jax)" --cov=docarray --cov-report=xml -v -s ${{ matrix.test-path }} --ignore=tests/integrations/store/test_jac.py
echo "flag it as docarray for codeoverage"
echo "codecov_flag=docarray" >> $GITHUB_OUTPUT
timeout-minutes: 30
Expand Down Expand Up @@ -167,7 +167,7 @@ jobs:
- name: Test
id: test
run: |
poetry run pytest -m 'proto' --cov=docarray --cov-report=xml tests
poetry run pytest -m 'proto' --cov=docarray --cov-report=xml -v -s tests
echo "flag it as docarray for codeoverage"
echo "codecov_flag=docarray" >> $GITHUB_OUTPUT
timeout-minutes: 30
Expand Down Expand Up @@ -217,7 +217,7 @@ jobs:
- name: Test
id: test
run: |
poetry run pytest -m 'index and not elasticv8' --cov=docarray --cov-report=xml tests/index/${{ matrix.db_test_folder }}
poetry run pytest -m 'index and not elasticv8' --cov=docarray --cov-report=xml -v -s tests/index/${{ matrix.db_test_folder }}
echo "flag it as docarray for codeoverage"
echo "codecov_flag=docarray" >> $GITHUB_OUTPUT
timeout-minutes: 30
Expand Down Expand Up @@ -267,7 +267,7 @@ jobs:
- name: Test
id: test
run: |
poetry run pytest -m 'index and elasticv8' --cov=docarray --cov-report=xml tests
poetry run pytest -m 'index and elasticv8' --cov=docarray --cov-report=xml -v -s tests
echo "flag it as docarray for codeoverage"
echo "codecov_flag=docarray" >> $GITHUB_OUTPUT
timeout-minutes: 30
Expand Down Expand Up @@ -316,7 +316,7 @@ jobs:
- name: Test
id: test
run: |
poetry run pytest -m 'tensorflow' --cov=docarray --cov-report=xml tests
poetry run pytest -m 'tensorflow' --cov=docarray --cov-report=xml -v -s tests
echo "flag it as docarray for codeoverage"
echo "codecov_flag=docarray" >> $GITHUB_OUTPUT
timeout-minutes: 30
Expand Down Expand Up @@ -362,7 +362,7 @@ jobs:
- name: Test
id: test
run: |
poetry run pytest -m 'jax' --cov=docarray --cov-report=xml tests
poetry run pytest -m 'jax' --cov=docarray --cov-report=xml -v -s tests
echo "flag it as docarray for codeoverage"
echo "codecov_flag=docarray" >> $GITHUB_OUTPUT
timeout-minutes: 30
Expand Down Expand Up @@ -406,7 +406,7 @@ jobs:
- name: Test
id: test
run: |
poetry run pytest -m 'benchmark' --cov=docarray --cov-report=xml tests
poetry run pytest -m 'benchmark' --cov=docarray --cov-report=xml -v -s tests
echo "flag it as docarray for codeoverage"
echo "codecov_flag=docarray" >> $GITHUB_OUTPUT
timeout-minutes: 30
Expand Down
2 changes: 2 additions & 0 deletions tests/integrations/store/test_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ def test_list_and_delete(tmp_path: Path):
), 'Deleting a non-existent DA should return False'


@pytest.mark.skip(reason='Skip it!')
def test_concurrent_push_pull(tmp_path: Path):
# Push to DA that is being pulled should not mess up the pull
namespace_dir = tmp_path
Expand Down Expand Up @@ -212,6 +213,7 @@ def _task(choice: str):
p.map(_task, ['pull', 'push', 'pull'])


@pytest.mark.skip(reason='Skip it!')
@pytest.mark.slow
def test_concurrent_push(tmp_path: Path):
# Double push should fail the second push
Expand Down
5 changes: 5 additions & 0 deletions tests/integrations/store/test_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ def testing_bucket(minio_container):
s3.Bucket(BUCKET).delete()


@pytest.mark.skip(reason='Skip it!')
@pytest.mark.slow
def test_pushpull_correct(capsys):
namespace_dir = f'{BUCKET}/test{RANDOM}/pushpull-correct'
Expand Down Expand Up @@ -95,6 +96,7 @@ def test_pushpull_correct(capsys):
assert len(captured.err) == 0


@pytest.mark.skip(reason='Skip it!')
@pytest.mark.slow
def test_pushpull_stream_correct(capsys):
namespace_dir = f'{BUCKET}/test{RANDOM}/pushpull-stream-correct'
Expand Down Expand Up @@ -130,6 +132,7 @@ def test_pushpull_stream_correct(capsys):


# for some reason this test is failing with pydantic v2
@pytest.mark.skip(reason='Skip it!')
@pytest.mark.slow
def test_pull_stream_vs_pull_full():
namespace_dir = f'{BUCKET}/test{RANDOM}/pull-stream-vs-pull-full'
Expand Down Expand Up @@ -186,6 +189,7 @@ def get_total_full(url: str):
), 'Full pull memory usage should be dependent on the size of the data'


@pytest.mark.skip(reason='Skip it!')
@pytest.mark.slow
def test_list_and_delete():
namespace_dir = f'{BUCKET}/test{RANDOM}/list-and-delete'
Expand Down Expand Up @@ -220,6 +224,7 @@ def test_list_and_delete():
), 'Deleting a non-existent DA should return False'


@pytest.mark.skip(reason='Skip it!')
@pytest.mark.slow
def test_concurrent_push_pull():
# Push to DA that is being pulled should not mess up the pull
Expand Down