Skip to content

fix: from_dataframe with numpy==1.26.1 and type handling in python 3.9 #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 6 commits into from
Oct 23, 2023
Merged

fix: from_dataframe with numpy==1.26.1 and type handling in python 3.9 #1823

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1627693
ci: use python 3.9 and newer numpy version
JohannesMessner Oct 18, 2023
c8fd648
ci: try to fix syntax error (?)
JohannesMessner Oct 18, 2023
0bab36e
fix: from_dataframe with current numpy
JohannesMessner Oct 18, 2023
3b778f0
test: change test that is broken by numpy upgrade
JohannesMessner Oct 18, 2023
5e9b809
fix: get args of paremtrized types
JohannesMessner Oct 18, 2023
b70a669
test: add test with 0 length numpy array
JohannesMessner Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
ci: use python 3.9 and newer numpy version 
Signed-off-by: Johannes Messner <[email protected]>
  • Loading branch information
@JohannesMessner
JohannesMessner committed Oct 18, 2023
commit 16276939d623e4558b2de2b1419c4801b662c569
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.8]
python-version: [3.9]
pydantic-version: ["pydantic-v2", "pydantic-v1"]
test-path: [tests/integrations, tests/units, tests/documentation]
steps:
Expand All @@ -112,6 +112,11 @@ jobs:
./scripts/install_pydantic_v2.sh ${{ matrix.pydantic-version }}
poetry run pip uninstall -y torch
poetry run pip install torch
# Issue https://github.com/docarray/docarray/issues/1821 occurs with a numpy version
# that is only supported in pyton 3.9 and up.
# Poetry cannot lock to that version because we support python 3.8.
# Therefore, we install this version manually to test for the error in the CI.
poetry run pip install numpy==1.26.1
sudo apt-get update
sudo apt-get install --no-install-recommends ffmpeg

Expand Down