Skip to content

fix: fix double subscriptable error #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 3 commits into from
Sep 27, 2023
Merged

fix: fix double subscriptable error #1800

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc41eb0
fix: fix double subscriptable error
Sep 19, 2023
fb71c56
Merge branch 'main' into fix-double-subscriptable
Sep 27, 2023
ddd013c
Merge branch 'main' into fix-double-subscriptable
Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into fix-double-subscriptable 
Signed-off-by: Joan Fontanals <[email protected]>
  • Loading branch information
Joan Fontanals authored Sep 27, 2023
commit fb71c56e0cf4debdc8e1ba043e46d895522d3153
2 changes: 1 addition & 1 deletion docarray/array/doc_list/doc_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ def __getitem__(self, item):
return super().__getitem__(item)

@classmethod
def __class_getitem__(cls, item: Union[Type[BaseDoc], TypeVar, str]):
def __class_getitem__(cls, item: Union[Type[BaseDocWithoutId], TypeVar, str]):
if cls.doc_type != AnyDoc:
raise TypeError(f'{cls} object is not subscriptable')

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.