Skip to content

docs: add workaround for torch compile #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsja merged 12 commits into from
Aug 29, 2023
Merged

docs: add workaround for torch compile #1754

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
49eb47b
docs: add workaround for torch compile
JohannesMessner Aug 15, 2023
ce06855
docs: fix link
JohannesMessner Aug 15, 2023
10d2c54
chore: update torch version in lock file to enable torch compile
JohannesMessner Aug 15, 2023
731d37d
ci: install torch manually
JohannesMessner Aug 16, 2023
6c4927a
fix: revert torch dependecy commits
JohannesMessner Aug 24, 2023
fdb0e31
chore: update torch through poetry
JohannesMessner Aug 24, 2023
a281ea3
ci: uninstall and install torch to hopefully fix stuff
JohannesMessner Aug 28, 2023
3e93dfd
ci: confirm uninstall
JohannesMessner Aug 28, 2023
dfe4be2
ci: apply torch trick to all tests
JohannesMessner Aug 28, 2023
c3177e3
ci: torch trick during test setup
JohannesMessner Aug 28, 2023
5256a07
ci: install torch even for jax and tf tests
JohannesMessner Aug 28, 2023
374abbd
Merge branch 'main' into docs-torch-compile
JohannesMessner Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: fix link 
Signed-off-by: Johannes Messner <[email protected]>
  • Loading branch information
@JohannesMessner
JohannesMessner committed Aug 15, 2023
commit ce068552f972cbc6749abc5400f68442582c619f
2 changes: 2 additions & 0 deletions docarray/typing/tensor/torch_tensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,10 @@ class MyDoc(BaseDoc):

---


## Compatibility with `torch.compile()`


PyTorch 2 [introduced compilation support](https://pytorch.org/blog/pytorch-2.0-release/) in the form of `torch.compile()`.

Currently, **`torch.compile()` does not properly support subclasses of `torch.Tensor` such as `TorchTensor`**.
Expand Down
2 changes: 1 addition & 1 deletion docs/data_types/tensor/tensor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,4 +228,4 @@ PyTorch 2 [introduced compilation support](https://pytorch.org/blog/pytorch-2.0-
Currently, **`torch.compile()` does not properly support subclasses of `torch.Tensor` such as [`TorchTensor`][docarray.typing.tensor.TorchTensor]**.
The PyTorch team is currently working on a [fix for this issue](https://github.com/pytorch/pytorch/pull/105167#issuecomment-1678050808).

For a workaround to this issue, see [`TorchTensor`][docarray.typing.tensor.TorchTensor#Compatibility-with-torch-compile]
For a workaround to this issue, see the [`TorchTensor` API reference][docarray.typing.tensor.TorchTensor].