-
Notifications
You must be signed in to change notification settings - Fork 235
fix: fix readme test #1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix readme test #1746
Conversation
|
Not sure to understand how this fixes it |
Signed-off-by: samsja <[email protected]>
basically the test is falling bc we try to run the jina part of the readme without installing jina. I just added jina to the ignore argument like we do with fastapi and all. So it should fix it (hopefully) |
|
I see, that makes sense. |
|
📝 Docs are deployed on https://ft-fix-test--jina-docs.netlify.app 🎉 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1746 +/- ##
===========================================
+ Coverage 30.06% 84.99% +54.93%
===========================================
Files 133 134 +1
Lines 8731 8838 +107
===========================================
+ Hits 2625 7512 +4887
+ Misses 6106 1326 -4780
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I have no clue honestly |
Context
will fix broken ci and test coverage on main