Skip to content

fix: tensor equals type raises exception #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 4 commits into from
Jul 31, 2023
Merged

fix: tensor equals type raises exception #1739

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5f590e
fix: equality between and abstracttensor and type
JohannesMessner Jul 31, 2023
6dbcaa7
test: add test for this case
JohannesMessner Jul 31, 2023
b363381
test: add comment to test
JohannesMessner Jul 31, 2023
55ba014
fix: comparison of mro's
JohannesMessner Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add comment to test 
Signed-off-by: Johannes Messner <[email protected]>
  • Loading branch information
@JohannesMessner
JohannesMessner committed Jul 31, 2023
commit b36338134d0c98c58bcfd8a967bab3f679412735
1 change: 1 addition & 0 deletions tests/units/typing/tensor/test_tensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,5 @@ class MyTensorDoc(BaseDoc):


def test_equals_type():
# see https://github.com/docarray/docarray/pull/1739
assert not (TorchTensor == type)