Skip to content

fix: fix call to unsafe issubclass #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 1 commit into from
Jul 27, 2023
Merged

fix: fix call to unsafe issubclass #1731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: fix call to unsafe issubclass
  • Loading branch information
Joan Fontanals Martinez committed Jul 27, 2023
commit 4589783c48dc3cbe0efd31595626d722b0613e09
2 changes: 1 addition & 1 deletion docarray/index/abstract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,7 +994,7 @@ def _validate_docs(
# see schema translation ideas in the design doc
names_compatible = reference_names == input_names
types_compatible = all(
(issubclass(t2, t1))
(safe_issubclass(t2, t1))
for (t1, t2) in zip(reference_types, input_types)
)
if names_compatible and types_compatible:
Expand Down