Skip to content

refactor: do not recompute every time num_docs #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 3 commits into from
Jul 26, 2023
Merged

refactor: do not recompute every time num_docs #1729

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f95b623
refactor: do not recompute every time num_docs
Jul 26, 2023
3ca5780
fix: k more than num docs
jupyterjazz Jul 26, 2023
dbdc990
Merge branch 'main' of https://github.com/docarray/docarray into fix-…
Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' of https://github.com/docarray/docarray into fix-… 
…num-docs

Signed-off-by: Joan Fontanals Martinez <[email protected]>
  • Loading branch information
Joan Fontanals Martinez committed Jul 26, 2023
commit dbdc99003b98fb8f1635e9fdec8ad69a1391e2ba
7 changes: 5 additions & 2 deletions docarray/index/backends/hnswlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,8 +627,11 @@ def accept_hashed_ids(id):

# If hashed_ids is provided, k is the minimum of limit and the length of hashed_ids; else it is limit
k = min(limit, len(hashed_ids)) if hashed_ids else limit

labels, distances = index.knn_query(queries, k=k, **extra_kwargs)
try:
labels, distances = index.knn_query(queries, k=k, **extra_kwargs)
except RuntimeError:
k = min(k, self.num_docs())
labels, distances = index.knn_query(queries, k=k, **extra_kwargs)

result_das = [
self._get_docs_sqlite_hashed_id(
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.