Skip to content

fix: use safe_issubclass everywhere #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 2 commits into from
Jul 10, 2023
Merged

fix: use safe_issubclass everywhere #1691

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15f34b8
fix: use safe_issubclass everywhere
Jul 10, 2023
cfac5f1
Merge branch 'main' into fix-is-subclass
Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into fix-is-subclass 
Signed-off-by: Joan Fontanals Martinez <[email protected]>
  • Loading branch information
Joan Fontanals committed Jul 10, 2023
commit cfac5f197104c1f457c32da76dd94396a35f4b62
4 changes: 2 additions & 2 deletions docarray/index/backends/redis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def _create_index(self) -> None:
if not self._check_index_exists(self.index_name):
schema = []
for column, info in self._column_infos.items():
if issubclass(info.docarray_type, AnyDocArray):
if safe_issubclass(info.docarray_type, AnyDocArray):
continue
elif info.db_type == VectorField:
space = info.config.get('space') or info.config.get('distance')
Expand Down Expand Up @@ -286,7 +286,7 @@ def python_type_to_db_type(self, python_type: Type) -> Any:
}

for py_type, redis_type in type_map.items():
if issubclass(python_type, py_type):
if safe_issubclass(python_type, py_type):
return redis_type
raise ValueError(f'Unsupported column type for {type(self)}: {python_type}')

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.