Skip to content

feat: validate file formats in url (#1606) #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 24 commits into from
Jun 27, 2023
Merged

feat: validate file formats in url (#1606) #1669

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
49fd592
feat: validate file formats in url (#1606)
makram93 Jun 26, 2023
5680e0d
test: reverting some changes
jupyterjazz Jun 26, 2023
0ce7e54
chore: add prints
jupyterjazz Jun 26, 2023
c1e1528
style: run black
jupyterjazz Jun 26, 2023
5591d3e
chore: print values
jupyterjazz Jun 26, 2023
d4a289f
feat: initialize mime types
jupyterjazz Jun 26, 2023
a69c197
refactor: file name
jupyterjazz Jun 26, 2023
fa0dbb2
refactor: rename again
jupyterjazz Jun 26, 2023
d438dc6
refactor: remove special cases
jupyterjazz Jun 26, 2023
d0948fc
test: resolve some tests
jupyterjazz Jun 26, 2023
5222026
refactor: remove custom mimetypes
jupyterjazz Jun 26, 2023
08c8b3b
test: add a valid link
jupyterjazz Jun 26, 2023
262190f
refactor: just want to make ci green am i asking too much?
jupyterjazz Jun 26, 2023
c661282
refactor: validate approach, should fail
jupyterjazz Jun 26, 2023
7644d6d
refactor: text link
jupyterjazz Jun 26, 2023
fbe7d7c
test: resolve tests
jupyterjazz Jun 26, 2023
4ee48f3
refactor: polish up the code
jupyterjazz Jun 26, 2023
1a69277
style: run black
jupyterjazz Jun 26, 2023
02c15c6
refactor: add constants, update 3d mimetype
jupyterjazz Jun 26, 2023
32cc3ab
test: resolve tests
jupyterjazz Jun 26, 2023
730f21b
refactor: remove prints
jupyterjazz Jun 27, 2023
9464fb7
feat: pass validation for urls with not ext
jupyterjazz Jun 27, 2023
ee29f6a
refactor: get ext
jupyterjazz Jun 27, 2023
70d4970
test: resolve unit tests
jupyterjazz Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: resolve tests 
Signed-off-by: jupyterjazz <[email protected]>
  • Loading branch information
@jupyterjazz
jupyterjazz committed Jun 26, 2023
commit fbe7d7c527506cbf7fdecc230fb3463d28423a47
4 changes: 2 additions & 2 deletions docarray/documents/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ class MultiModalDoc(BaseDoc):
```python
from docarray.documents import TextDoc

doc = TextDoc(text='This is the main text', url='exampleurl.com')
doc2 = TextDoc(text='This is the main text', url='exampleurl.com')
doc = TextDoc(text='This is the main text', url='exampleurl.com/file.txt')
doc2 = TextDoc(text='This is the main text', url='exampleurl.com/file.txt')

doc == 'This is the main text' # True
doc == doc2 # True
Expand Down
2 changes: 1 addition & 1 deletion tests/units/typing/url/test_text_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def test_load(url, expected_beginning):
uri = parse_obj_as(TextUrl, url)

txt = uri.load()
assert txt.startswith(expected_beginning)
assert expected_beginning in txt


@pytest.mark.slow
Expand Down