Skip to content

refactor: more robust method to detect duplicate index #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsm207 merged 9 commits into from
Jul 10, 2023
Merged

refactor: more robust method to detect duplicate index #1651

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c98f6f6
chore: update weaviate dependency
hsm207 Jun 15, 2023
a386374
chore: pin weaviate-client
hsm207 Jun 15, 2023
c57d576
Merge branch 'main' of https://github.com/docarray/docarray into hsm2…
hsm207 Jul 10, 2023
6cb8810
refactor: rewrite schema check for reuse
hsm207 Jul 10, 2023
eb3c3d2
chore: update lock file
hsm207 Jul 10, 2023
5f29aca
Merge branch 'main' into hsm207/refactor-duplicate-index
Jul 10, 2023
8d0f792
Revert "chore: update lock file"
hsm207 Jul 10, 2023
c7976bd
Merge branch 'main' of https://github.com/docarray/docarray into hsm2…
hsm207 Jul 10, 2023
fb48a40
chore: get poetry.lock from main branch
hsm207 Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: rewrite schema check for reuse
  • Loading branch information
@hsm207
hsm207 committed Jul 10, 2023
commit 6cb88102a8dbe47c6f96db5e030c65426ec0c30f
4 changes: 1 addition & 3 deletions docarray/index/backends/weaviate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,7 @@ def _create_schema(self) -> None:
schema["properties"] = properties
schema["class"] = self.index_name

# TODO: Use exists() instead of contains() when available
# see https://github.com/weaviate/weaviate-python-client/issues/232
if self._client.schema.contains(schema):
if self._client.schema.exists(self.index_name):
logging.warning(
f"Found index {self.index_name} with schema {schema}. Will reuse existing schema."
)
Expand Down